Expand bundled gear library; load bundled gear/crosstalk live instead of seeding#414
Merged
Conversation
…ere film stocks Rounds out the bundled gear library: current and historical Leica M-mount lenses and bodies, Vision3 250D/500T in both remjet and AHU variants, and Ilford/Kentmere black & white stocks alongside the existing HP5.
Gear and crosstalk profiles used to be copied into the user's docs folder on first launch, so bundled updates in later releases never reached installs that were already seeded. Both now load bundled data straight from the app bundle and merge it with the user's own additions (deduped by id/name, bundled wins), so future gear/crosstalk additions show up for everyone automatically. Bundled gear entries are read-only in the Gear Library dialog; duplicating one makes an editable, persistable copy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
seed_example()→ensure_user_dir()). Both now read bundled data straight from the app bundle and merge it with the user's own additions, deduped by id/name with bundled taking priority — so future bundled additions reach every install automatically, and stale copies left over from the old seeding behavior stop showing as duplicates.Test plan
make all(ruff format/lint, ty type check, full pytest suite — 1180 passed)tests/metadata/test_gear_payload.py) and crosstalk (tests/test_crosstalk_profiles.py), save-time exclusion of bundled gear items, dialog duplicate-then-persist flow